feat(cmn): hard stop on multiple exit signals#2378
Merged
mergify[bot] merged 2 commits intodevelopfrom Mar 31, 2022
Merged
Conversation
🦋 Changeset detectedLatest commit: 786e93a The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Looks like a circle ci error is breaking the tests, not exactly sure what is going on |
tynes
reviewed
Mar 30, 2022
Adds a new feature to BaseServiceV2 to have a service exit immediately when 3 exit signals are received. Useful when the main loop would take a long time to exit but you want the service to exit immediately.
smartcontracts
force-pushed
the
sc/cmn-max-signals
branch
from
bd198da to
fbdb779
Compare
tynes
approved these changes
Mar 31, 2022
mslipper
approved these changes
Mar 31, 2022
Merged
nebojsa94
pushed a commit
to Tenderly/optimism
that referenced
this pull request
Apr 26, 2022
Adds a new feature to BaseServiceV2 to have a service exit immediately when 3 exit signals are received. Useful when the main loop would take a long time to exit but you want the service to exit immediately. Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
theochap
added a commit
that referenced
this pull request
Dec 10, 2025
) ## Description Rewire the sequencer unsafe payload sender from the engine to the network. Previously, the sequencer was sending the unsafe blocks it received from the network `BuildTask` back to the network to call `InsertUnsafeTask`. Since the `BuildTask` inserts the newly built payloads to the engine state (like what the `InsertUnsafeTask` would do), this resulted in a no-op. Instead, the sequencer should send the payloads to the network to gossip them to the p2p mesh. ## Misc Close #2244 Built on top of #2376
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new feature to BaseServiceV2 to have a service exit immediately
when 3 exit signals are received. Useful when the main loop would take a
long time to exit but you want the service to exit immediately.